Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension active despite being disabled in extension settings #197

Open
GrizzoCH opened this issue Jul 28, 2022 · 8 comments
Open

Extension active despite being disabled in extension settings #197

GrizzoCH opened this issue Jul 28, 2022 · 8 comments

Comments

@GrizzoCH
Copy link

Shortcuts edit video aspect ratio despite the extension being disabled in Extension settings

To Reproduce
Opened Youtube and disabled the extension. Problem persist on page reloads.

Expected behavior
The Extension should not interact with the open page unless activated

Browser and OS

  • Browser/browser version: Firefox 103.0
  • Operating system: Win 11
  • Ultrawidify version: 5.1.2

Additional info

@tamius-han
Copy link
Owner

tamius-han commented Jul 28, 2022

Hi,

I'm having a bit of trouble reproducing this problem. Can you please export your extension settings and attach them to this issue?

Go to about:addons, find Ultrawidify, open preferences, click 'export settings' at the bottom.
image

Thanks in advance.

@Amadeus-AI
Copy link

This issue also happens to me (Win10, firefox103, 5.1.2, with 21:9 screen), setting the video alignment still work after I choose "Never" on "Enable This extension".

@GrizzoCH
Copy link
Author

Hi,

I'm having a bit of trouble reproducing this problem. Can you please export your extension settings and attach them to this issue?

Go to about:addons, find Ultrawidify, open preferences, click 'export settings' at the bottom. image

Thanks in advance.

I've played around with it again after. From what I can tell it remains active on the youtube tab/session after switching from enabled to disabled. That persists while browsing youtube, through playlists and autoplay (giving the appearance of persisting on page load). It does not persist on loading YT on a new tab.

Attached (in txt because github doesn't like json):
ultrawidify-settings.json.txt

It feels like it saves the disabled setting, but only reads that change when opening YT in a new tab, rather than immediately/on video load.

@tamius-han
Copy link
Owner

I've played around with it again after. From what I can tell it remains active on the youtube tab/session after switching from enabled to disabled. That persists while browsing youtube, through playlists and autoplay (giving the appearance of persisting on page load). It does not persist on loading YT on a new tab.

Bit strange it remains active after page reload, but not on the new tab. I've also tried to reproduce the issue with the provided settings, but on my machine the extension gets disabled after page reload. I'll prolly have to investigate further.

In the mean time
Extension also has an option that disables keyboard shortcuts only (but does not disable extension entirely, meaning video can still be cropped/stretched from the popup):
image

@GrizzoCH
Copy link
Author

I would assume it is due to youtube not fully reloading when navigating within the page. As mentioned it only persist while navigating within youtube.

A partial reload through F5 does disable the extension.

being aware of that I don't consider it a significant issue. but it will be useful to keep in mind that youtube's internal navigation seems to not fully reload the settings.

@Amadeus-AI
Copy link

In my case, Reload through F5 doesn't disable the extension. The video alignment still effect.

@tamius-han
Copy link
Owner

@Amadeus-AI hi,

  • can I get your settings? (See my first reply for how to export)
  • does the issue persist in a new tab?
  • what browser/OS?

Thanks in advance.

@Amadeus-AI
Copy link

ultrawidify-settings.json.txt

firefox 104 / win10

yes, the issue persist in a new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants