Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG Font-Type duplicate icon with fileName as unicode #154

Closed
dobbidev opened this issue Mar 18, 2021 · 2 comments
Closed

SVG Font-Type duplicate icon with fileName as unicode #154

dobbidev opened this issue Mar 18, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dobbidev
Copy link

Hello,

The SVG Font-Type generates a duplication of one icon:
image
The first is the normal (expected) icon, the second has the glyph-name as unicode name.

The old package icon-font-generator was not doing something like this.

I think the position of this behavior is here:

glyph.metadata = { name: id, unicode: [unicode, ligature] };

Problem
The svg file gets very big: 2-3x bigger then normal.

Is that wanted? When yes, is there a solution provided where i can deactivate this behavior?

Thanks

Dobbi

@tancredi tancredi added the bug Something isn't working label May 15, 2021
@tancredi
Copy link
Owner

Hi @dobbidev - merged a PR that should address this - please let me know if there's any issues with it

@tancredi
Copy link
Owner

(fix available in v1.2.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants