Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Although this extension is great, it kind of worries me... #1

Open
MathEnthusiast314 opened this issue Jan 20, 2022 · 4 comments
Open

Comments

@MathEnthusiast314
Copy link

MathEnthusiast314 commented Jan 20, 2022

A better thing would be to link a local file to desmos and keep auto saving it to that file instead of creating a new graph link by Ctrl+S every 30 seconds or so :(
Will cost too much on desmos servers and is not really worth it because desmos already implemented an "attempt recovery" feature.

@tandpfun
Copy link
Owner

You probably know a lot mode about Desmos than me, but doesn't every method of saving create a new link?
I do think that I can remove some of the faster savings, like "10s", as those can cause some glitches.

I don't think it'll cause too much of a toll on Desmos, because you can also just hold down "cmd-s" to have the same effect but much faster. If there was a problem, they could implement ratelimits to prevent something like that.

Thank you for your concern though!

@MathEnthusiast314
Copy link
Author

Yes, every Ctrl+S creates a new link but that wasn't the point.

The point was that graph links are being created quickly even where subsequent graphs don't differ by a lot.

Destree: https://www.youtube.com/watch?v=Vks56T679ZQ&ab_channel=MathEnthusiast314

Sometimes when I render the destree I see huge chunks of the destree when graphs have a lot of graph history. This is mainly due to when users extensively save their graphs and when similarity percentages between versions of the graph is very close to 100%. This is also being done by userscripts and extensions.

Personally I save graphs only after I make a lot of progress on the graph (because we already have the 'attempt recovery' feature if something is lost). The similarity percentage between adjacent versions of my graphs is always <70%.

I also made a discord bot which specifically shows users the differences between graphs and a lot of the times I come across versions whose similarity percentage is 100% which overturns the whole point of showing the differences between graph expressions.
image_2022-03-07_174750

This has to change for projects that work with graph history and it's ideal if there's not much clutter.

@tandpfun
Copy link
Owner

tandpfun commented Mar 7, 2022

This makes sense, yeah. I don't think it's going to be easy to detect similarly and stuff (and I don't know if everyone wants that) but I can make it detect if the project has changes before saving.

I think that I need to revisit this and take a better look at how I can better integrate it with the program.

By the way, that's a really cool project!! I hope you don't mind if I poke around the code a bit to better understand desmos programs.

I really appreciate your concerns, expecially from someone who's a lot more experienced with the program!!

@MathEnthusiast314
Copy link
Author

Thanks! Yeah I don't mind you poking around the code:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants