New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plural should not have indefinite article #23
Comments
Quick workaround: // @flow
import indefinite from 'indefinite';
import pluralize from 'pluralize';
export default (subject: string): string => {
if (pluralize(subject) === subject) {
return subject;
}
return indefinite(subject);
}; |
Currently indefinite doesn't attempt to know whether something should have an indefinite article or not, only which one to use (
To that last point, it's obviously sort of related, so I can see a case for including it, but the other two points seem prohibitive at the moment. If I added this, I think I'd maybe not want to use pluralize, but then I'm not sure I want to try to maintain whatever I wrote in its place. |
Just document the workaround in the docs. No need to depend on |
Sounds good. Thanks. |
Updated the readme. |
The text was updated successfully, but these errors were encountered: