Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-segment transformation and deformation motion blur #85

Closed
dedoardo opened this issue Mar 11, 2021 · 3 comments · Fixed by #148
Closed

Multi-segment transformation and deformation motion blur #85

dedoardo opened this issue Mar 11, 2021 · 3 comments · Fixed by #148
Assignees
Labels
enhancement New feature or request in discussion Still requires a discussion question Further information is requested

Comments

@dedoardo
Copy link
Contributor

The motion blur code in HdCyclesMesh uses a fixed number of motion steps HD_CYCLES_MOTION_STEPS for both transformation and deformation blur. Deformation blur is also always turned on which could results in additional copies of the mesh as the points are not tested to be time varying before they are sampled and copied to the Cycles mesh. The code mentions that it depends on the Schema PR, maybe we can wait for that to clear up the logic.

Changing it requires a bit of refactoring. Are there possible complications to changing it?

@dedoardo dedoardo added question Further information is requested in discussion Still requires a discussion labels Mar 11, 2021
@bareya
Copy link
Collaborator

bareya commented Mar 12, 2021

Hey @dedoardo I totally agree with you that we should have it optimized. I think the number of steps for the specific object should come from the schema. We definitely should have a look into this.

@bareya bareya added the enhancement New feature or request label Mar 12, 2021
@bareya bareya added this to High priority in HdCycles Development Mar 23, 2021
@bareya
Copy link
Collaborator

bareya commented Apr 19, 2021

This is very closely related to #122. After we merge usd cycles support we can proceed with better motion blur support.

@bareya bareya self-assigned this Apr 28, 2021
@bareya bareya moved this from High priority to In Progress in HdCycles Development Apr 28, 2021
@bareya bareya linked a pull request Apr 28, 2021 that will close this issue
@bareya bareya changed the title Mesh motion blur steps and deform Multi-segment transformation and deformation motion blur Apr 29, 2021
@bareya
Copy link
Collaborator

bareya commented Apr 29, 2021

I took the liberty and I renamed this ticket to make it more broad. To tackle it at once it's a bit of effort. I think we can break it down to few extra tickets:

  • Transformation motion blur
  • Deformation motion blur

At this moment I am kind of in advanced stage of the implementation of transformation motion blur. For deformation motion blur, we would have to refactor the code in few places. For instance for meshes we would have to take into an account possibility of heaving meshes subdivided. During the implementation of deformation motion blur we could refactor Cycles a bit and implement HdCyclesStandardAttributeSource. That class would help us to add standard attributes to resource registry.

@bareya bareya added this to Needs triage in HdBlackbird Development via automation May 3, 2021
@bareya bareya moved this from Needs triage to In Progress in HdBlackbird Development May 3, 2021
@bareya bareya removed this from In Progress in HdCycles Development May 3, 2021
@bareya bareya linked a pull request May 4, 2021 that will close this issue
@bareya bareya removed a link to a pull request May 4, 2021
@bareya bareya moved this from In Progress to Waiting For Feedback in HdBlackbird Development May 5, 2021
HdBlackbird Development automation moved this from Waiting For Feedback to Merged May 6, 2021
@bareya bareya moved this from Merged to In Progress in HdBlackbird Development May 7, 2021
@bareya bareya moved this from In Progress to Needs triage in HdBlackbird Development May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in discussion Still requires a discussion question Further information is requested
Projects
Development

Successfully merging a pull request may close this issue.

2 participants