-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-segment transformation and deformation motion blur #85
Comments
Hey @dedoardo I totally agree with you that we should have it optimized. I think the number of steps for the specific object should come from the schema. We definitely should have a look into this. |
This is very closely related to #122. After we merge usd cycles support we can proceed with better motion blur support. |
I took the liberty and I renamed this ticket to make it more broad. To tackle it at once it's a bit of effort. I think we can break it down to few extra tickets:
At this moment I am kind of in advanced stage of the implementation of transformation motion blur. For deformation motion blur, we would have to refactor the code in few places. For instance for meshes we would have to take into an account possibility of heaving meshes subdivided. During the implementation of deformation motion blur we could refactor Cycles a bit and implement |
The motion blur code in
HdCyclesMesh
uses a fixed number of motion stepsHD_CYCLES_MOTION_STEPS
for both transformation and deformation blur. Deformation blur is also always turned on which could results in additional copies of the mesh as the points are not tested to be time varying before they are sampled and copied to the Cycles mesh. The code mentions that it depends on the Schema PR, maybe we can wait for that to clear up the logic.Changing it requires a bit of refactoring. Are there possible complications to changing it?
The text was updated successfully, but these errors were encountered: