Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 9 support #19

Closed
Ewg777 opened this issue Aug 5, 2015 · 7 comments
Closed

iOS 9 support #19

Ewg777 opened this issue Aug 5, 2015 · 7 comments

Comments

@Ewg777
Copy link

Ewg777 commented Aug 5, 2015

iOS 9 ignore cornerRadius error

@jeroentrappers
Copy link
Contributor

This is due to the animation block. When pulling the code from the animation block, the corners are rounded again, but you lose the animation when the size of the badge is changed.

@m3ki
Copy link

m3ki commented Sep 1, 2015

Do you know of a way to fix this properly while keeping animation?

@m3ki
Copy link

m3ki commented Sep 1, 2015

I was able to fix this issue by changing the this code:

    [UIView animateWithDuration:duration animations:^{
        [self updateBadgeFrame];
    }];

to

self.badge.layer.masksToBounds = YES;
 [UIView animateWithDuration:duration animations:^{
     [self updateBadgeFrame];
 }];

@Broich
Copy link

Broich commented Sep 8, 2015

Wondering if this project is still alive enough to accept the pull request that fixes this issue.

@TanguyAladenise
Copy link
Owner

Hi guys,

Sorry for not being reactive on the repo. I have a lot on my plate and did not get the chance to work with it and maintain it.
I wanted to take some time to test the fixes and do some refactoring for a new version.
Anyway I will try to do better next time ;)

@Broich
Copy link

Broich commented Sep 8, 2015

Awesome! Great news, thank you!

@gabmarfer
Copy link

Please, could you update the pod spec version to match the latest code version?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants