Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When setting badgeValue to nil, the badge still shows, even after shouldHideBadgeAtZero set as YES #4

Closed
dzenbot opened this issue Mar 14, 2014 · 1 comment
Closed

When setting badgeValue to nil, the badge still shows, even after shouldHideBadgeAtZero set as YES #4

dzenbot opened this issue Mar 14, 2014 · 1 comment

Comments

@dzenbot
Copy link

dzenbot commented Mar 14, 2014

Sorry, I found another small bug. I accidentally set nil, instead of "0", to badgeValue, and the badge still shows even after shouldHideBadgeAtZero is set as YES.

The expected behaviour should be that the badge don't show when nil value, since nil is somehow the same than 0. What do you think?

image
@TanguyAladenise
Copy link
Owner

That was just wrong... sorry.
I consider that if the badgeValue is set to nil or with an empty string it should removed.
Zero is a special case, because zero could be considered as an info to the user. Whereas an empty string and nil definitely not.
Thanks for your help.

Repo and pod updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzenbot @TanguyAladenise