-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming convention for counter designs #10
Comments
@anaszameer-rs Let me know what you think. See if we can apply to all the counter designs. |
@tangxifan Just a suggestion! Wouldn't that be great if we use resetp | resetn instead of resetb to make it more clear? |
@anaszameer-rs No problem for me. We should document it. Let me start documentation template this morning. Are you o.k. to write these down in the documentation? |
@anaszameer-rs If we follow the naming convention of |
@anaszameer-rs Kindly review the documentation about the naming rules at: https://micro-benchmark.readthedocs.io/en/latest/developer/naming_convention/#counter-design-names If you agree, we can close this issue. The rule will be actively applied in later PRs. |
@tangxifan Can we add more flexibility in counter design namings considering posedge | negedge | dual edge counters? |
Good catch. Please suggest and we can update naming rules. |
@tangxifan Can we add posedge | negedge | dualedge keywords for counter designs ? counting down |
@tangxifan Can you please confirm which naming convention should i follow for my upcoming PR for Counter designs ? |
@anaszameer-rs Let's follow the naming convention you have proposed. |
Is your feature request related to a problem? Please describe.
As we are enriching the counter RTL designs in https://github.com/tangxifan/micro_benchmark/tree/main/simple_registers/counters ,
it is time to establish naming convention for counters.
As such, developers can identify critical technical features from the name of a counter design.
Describe the solution you'd like
A naming convention could be
down
represent a counting down countersize
is an integer, indicating the number of bits for a counterasync
andsync
represent the feature of reset and set signalset
,reset
,setb
andresetb
indicates the existence of reset/set signal as well as polarity.For instance,
shows a counter with the following features:
The text was updated successfully, but these errors were encountered: