#77: Add in pause after specific interval, "skip" silences #71
Conversation
|
Awesome thanks! I'll look into this tonight |
|
So something I want to make sure is that the player itself is pretty light and extensible in terms of manipulations being attached to the engine. Meaning I want the player at the core to be almost like AVAudioEngine that can stream. But I also love your feature suggestions and think others would find super valuable! I'm looking now into extracting out these to be in their own namespace of "Extra Features" which wouldn't be as tightly coupled to the core engine source code but still give the same functionality. I'll co-commit these changes so that your changes exist in the adjacent namespace! |
|
|
||
| let meterLevel = self.scaledPower(power: avgPower) | ||
| if meterLevel < 0.6 { | ||
| self.changeRate(to: 1.5) |
There was a problem hiding this comment.
I don't want to use hardcoded 1.5 for speeding up to skip silences as they might have the audio rate set to 4 or something by default.
There's 2 options here:
- We change this to add to the current rate by some appropriate factor. I'm think this rate increase for skipping silences should be less at higher rates so we'd need to determine some sort of ratio.
- We assume that at rates above some number, like 3, the skip silences feature wouldn't be noticeable/helpful and then we could just restrict the rate change to a lower range of original rates. This makes it easy to just add some constant to the current rate.
There was a problem hiding this comment.
That's a really good point that I hadn't considered. I like both suggestions and think a mix of the two would be best? Applying some appropriate factor definitely seems the right way to go and if the rate increases beyond to a point where the skip would be negligible it just switches the tap off?
There was a problem hiding this comment.
Created an issue for this #82
|
I think I'd need to expose a point for taps like how we have one for audioModifiers to be fully extensible. |
|
@tanhakabir I wonder if it's worth pulling these out into two separate PR's? That way we can add a small feature increment whilst thinking a little more about how to approach skipping silences. |
|
@jw1540 yeah if you're able to separate them out that would be great! |
|
Hey @jw1540 what resources did you use for skipping silences? I want to document that in the code for future reference |
|
Asked for documentation in #81 |
PR adds a crude implementation on skipping silences. It basically checks when the average power for the currently playing buffer drops below an arbitrary value, and then increases the rate. Once the power returns above the value, the rate is reduced back to 1.0.
Pausing after a time just runs a timer for that period and then calls pause. Perhaps it should also observe the playing status and remove itself if the audio file ends prior to the timer completing?