Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: on-demand initializaiton #5

Merged
merged 3 commits into from Jun 30, 2022
Merged

feat: on-demand initializaiton #5

merged 3 commits into from Jun 30, 2022

Conversation

hasundue
Copy link
Contributor

Hi, tani san. Thank you for such a nice plugin!

This PR modifies glance to start the server when :Glance is executed, not when the plugin is loeded.
I believe this is always a better behavior, but I don't mind even if the feature is enabled by an option.

I did some refactoring as well.

denops/glance/main.ts Outdated Show resolved Hide resolved
denops/glance/main.ts Outdated Show resolved Hide resolved
denops/glance/main.ts Show resolved Hide resolved
denops/glance/main.ts Outdated Show resolved Hide resolved
@hasundue hasundue requested a review from tani June 30, 2022 04:42
@tani
Copy link
Owner

tani commented Jun 30, 2022

LGTM. Cheers 🍻

@tani tani merged commit 0bb04ea into tani:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants