Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servercheck: ability to connect via TCP instead of socket #11

Closed
pataquets opened this issue Jan 31, 2018 · 2 comments
Closed

servercheck: ability to connect via TCP instead of socket #11

pataquets opened this issue Jan 31, 2018 · 2 comments

Comments

@pataquets
Copy link

pataquets commented Jan 31, 2018

Although socket sounds the most natural and optimal way of connecting, adding TCP would add flexibility and enable a few other usage scenarios, such as non-local and/or containerized deployments.

Questions:

  • Is such feature supported? (I've looked at the code, but found nothing)
  • Is there interest in it? Would you have time/bandwith/need on coding it?
  • Would a suitable PR be accepted? (I'm not very deep in Go, but looks like a low hanging fruit and I might take a stab at it)
  • Which command-line switch name would be appropiate?
@tanji
Copy link
Owner

tanji commented Jan 31, 2018

It will take a few minutes for me to add it, I just didn't do it because I rarely use TCP on same machines, but as you said, it can help for container on non-local! I'll keep you posted!

@tanji tanji closed this as completed in c792ec7 Jan 31, 2018
@pataquets
Copy link
Author

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants