Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A branch for a private use was merged #2

Closed
yoichitgy opened this issue Aug 29, 2015 · 1 comment
Closed

A branch for a private use was merged #2

yoichitgy opened this issue Aug 29, 2015 · 1 comment

Comments

@yoichitgy
Copy link
Contributor

Thank you for merging my PR #1, but it actually looks my master branch is merged.

My master branch is for my private use, and it might not be useful for general users.

  • ShareThis button feature has hard-coded information of my API key.
  • ShareThis buttons are always displayed. They should be configurable by theme.toml.
  • highlight.js has only a few languages related to Swift.
  • custom.css is used. The style sheets should be moved to theme.less and theme.css for the users of this theme. Especially the color code used in custom.css should be moved to theme.less and theme.css.
  • Users can change the theme color in theme.less and compile it by one of online compilers. README.md can explain how to compile the LESS file.
  • README.md should be updated to tell about RSS and ShareThis settings.

I will fix the problems for the other users, and send a PR later.

I think this theme is simple and attractive for a lot of Hugo users. I would like to keep it usable for the users.

@yoichitgy
Copy link
Contributor Author

I sent pull requests #3 and #4 to resolve this issue.

Thank you for merging the ShareThis feature to your master branch at the last time. With the PRs, anyone can use ShareThis and other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant