Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Handle disconnecting players better #30

Closed
jftanner opened this issue Oct 27, 2020 · 2 comments
Closed

Handle disconnecting players better #30

jftanner opened this issue Oct 27, 2020 · 2 comments
Labels
enhancement New feature or request released in beta This feature/request/fix has been published in a beta release released This feature/request/fix has been published in a full release

Comments

@jftanner
Copy link
Member

Feature

From @douglasmonsky:

People should probably be auto ejected when they leave the voice channel (or maybe after being gone for say 5 mins). Even when telling people pretty much no one actually leaves to the session via the bot, they just leave.

Players should be removed from the bot automatically, where possible.

Reasons for Implementing

Players don't leave the bot (because why would they?) which means they are left hanging around until someone uses ejects them or ends the lobby. This just is inelegant and annoying.

Ideas & Details

Some options to think about:

  • For automated lobbies, switch players to spectator when they disconnect from the game. (This will need careful handling to work smoothly over lobby restarts.)
  • Automatically remove missing players during intermission.
    • Would need some way to auto-rejoin when they come back.
  • Always disconnect players when they change channels.
    • They need to automatically reconnect when re-joining the channel.
    • Need to lock the player so another user can't join as them.

Alternatives

@jftanner jftanner added the enhancement New feature or request label Oct 27, 2020
@Tanndev-CI
Copy link

This issue is resolved in version 2.6.0-beta.7

@Tanndev-CI Tanndev-CI added the released in beta This feature/request/fix has been published in a beta release label Oct 30, 2020
@Tanndev-CI
Copy link

This issue is resolved in version 2.6.0

@Tanndev-CI Tanndev-CI added the released This feature/request/fix has been published in a full release label Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released in beta This feature/request/fix has been published in a beta release released This feature/request/fix has been published in a full release
Development

No branches or pull requests

2 participants