fix(setQueryData): setQueryData(notInstantiatedQueryKey) now assigns …

…Promise.resolve() instead of new Promise(noop) that caused a never ending promise en certain scenarios. Ref bug #639 (#645)
TanStack · Jun 28, 2020 · 5546670 · 5546670
1 parent 11a9fd5
commit 5546670
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/queryCache.js b/src/queryCache.js
@@ -236,7 +236,7 @@ export function makeQueryCache() {
 
     if (!queries.length && typeof queryKey !== 'function') {
       queries = [
-        cache._buildQuery(queryKey, undefined, () => new Promise(noop), {
+        cache._buildQuery(queryKey, undefined, () => Promise.resolve(), {
           ...defaultConfigRef.current,
           ...config,
         }),

diff --git a/src/tests/queryCache.test.js b/src/tests/queryCache.test.js
@@ -192,4 +192,15 @@ describe('queryCache', () => {
     expect(newQuery.state.markedForGarbageCollection).toBe(false)
     expect(newQuery.state.data).toBe('data')
   })
+
+  // this covers bug https://github.com/tannerlinsley/react-query/issues/639
+  test('setQueryData of not instatiated query uses a resolved promise as queryFn', async () => {
+    let promiseIsResolved = false
+    const queryCache = makeQueryCache()
+    const queryKey = 'notInstantiated'
+    queryCache.setQueryData(queryKey, "data")
+    await queryCache.refetchQueries(queryKey, { force: true });
+    promiseIsResolved = true
+    expect(promiseIsResolved).toBe(true)
+  })
 })