Fix "No queryClient set" when hydrating #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/H9kyr9Xvc6UVpuJcYRXpNdtQt1vT |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af5bae3:
|
TkDodo
approved these changes
Apr 14, 2021
|
Doing some extra verification on our project at work before I merge this. |
|
🎉 This PR is included in version 3.13.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2112
This PR changes the relative import of
useQueryClientto an absolute one (from 'react-query'). As described in the issue, this is important to avoid bundling parts of the main package into the hydration entry point and fixes a bug caused by theQueryClientProvider-context not lining up between the different entry points.I've verified this fixes the broken NextJS-example as well as our code base at work.
Also added TS-resolves for this path so TS knows where to look for the types.
There are more relative imports in the hydration package, but they are all related to types which is fine.