Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing batch updates on Production #2703

Merged

Conversation

richardaum
Copy link
Contributor

@richardaum richardaum commented Sep 22, 2021

Description

Currently development and production bundles have differences that affects React Query batching update. Changing sideEffects makes both setBatchUpdatesFn and setLogger to be included on final production bundle without affecting development.

The thing here is to add index.js files to sideEffects as they calls the side effect directly. A similar code is available on webpack docs, which explains which files should be added there

Summary

  • fix(core): add index.js files to sideEffects

Related issues

#2675
#2644

@vercel
Copy link

vercel bot commented Sep 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/ErAK6EJQgFVgncPuUJyBjwWP38bj
✅ Preview: https://react-query-git-fork-richardaum-fix-missin-b7e3df-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76651fa:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.24.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants