Missing batch updates on Production #2703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently development and production bundles have differences that affects React Query batching update. Changing
sideEffects
makes bothsetBatchUpdatesFn
andsetLogger
to be included on final production bundle without affecting development.The thing here is to add index.js files to sideEffects as they calls the side effect directly. A similar code is available on webpack docs, which explains which files should be added there
Summary
Related issues
#2675
#2644