Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsubscribe leak #3092

Merged
merged 2 commits into from
Dec 14, 2021
Merged

fix: unsubscribe leak #3092

merged 2 commits into from
Dec 14, 2021

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Dec 14, 2021

No description provided.

@TkDodo
fix: remove window event listeners for onlineManager / focusManager w…
11e9d0d 
…hen the last subscriber unsubscribes
@TkDodo
fix: make sure the managers keep track of the latest setupFn
b789930 
now that we correctly unsubscribe, we could come into a situation where we unsubscibe, then subscribe again. If we have setup a custom event listener before that, we need to call that one, not the default one.
@vercel
Copy link

vercel bot commented Dec 14, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/3dSiHoipiGJDDnicxmMiZ4WwQRba
✅ Preview: https://react-query-git-fork-tkdodo-unsubscribe-leak-tanstack.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b789930:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Dec 14, 2021 •
edited

Codecov Report

Merging #3092 (b789930) into master (ca335de) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
+ Coverage   96.46%   96.47%   +0.01%     
==========================================
  Files          45       45              
  Lines        2261     2271      +10     
  Branches      641      641              
==========================================
+ Hits         2181     2191      +10     
  Misses         77       77              
  Partials        3        3
Impacted Files Coverage Δ
src/core/focusManager.ts 100.00% <100.00%> (ø)
src/core/onlineManager.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca335de...b789930. Read the comment docs.

@TkDodo TkDodo merged commit 128e578 into TanStack:master Dec 14, 2021
@TkDodo TkDodo deleted the unsubscribe-leak branch December 14, 2021 12:08
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TkDodo @tannerlinsley