Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove enabled condition in queryObserver #3093

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

JaeYeopHan
Copy link
Contributor

@JaeYeopHan JaeYeopHan commented Dec 14, 2021

closes #2434

(would a description be enough as an issue link?)

@vercel
Copy link

vercel bot commented Dec 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/2EYt5yceGE5Tzt9FdPiDb5FpoxU8
✅ Preview: https://react-query-git-fork-jaeyeophan-fix-issue-2434-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e17ce6d:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration
React Query Bug (suspense + enabled flag) Issue #2434

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #3093 (e17ce6d) into master (988ba10) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3093      +/-   ##
==========================================
- Coverage   96.46%   96.45%   -0.01%     
==========================================
  Files          45       45              
  Lines        2261     2259       -2     
  Branches      641      639       -2     
==========================================
- Hits         2181     2179       -2     
  Misses         77       77              
  Partials        3        3              
Impacted Files Coverage Δ
src/core/queryObserver.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988ba10...e17ce6d. Read the comment docs.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the test from the issue, thanks.

@JaeYeopHan
Copy link
Contributor Author

please add the test from the issue, thanks.

OMG, every changes are not committed!! sorry...

@JaeYeopHan
Copy link
Contributor Author

JaeYeopHan commented Dec 14, 2021

node 14...? 🥲 jsut format :)

@TkDodo TkDodo merged commit 0781142 into TanStack:master Dec 14, 2021
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JaeYeopHan JaeYeopHan deleted the fix/issue-2434 branch December 14, 2021 12:32
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinate querying when query fails and using suspense + enabled flag
3 participants