Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): set error to null when going to loading state #3106

Merged
merged 1 commit into from Dec 17, 2021

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Dec 17, 2021

to be aligned with the types, as loading cannot have an error set.

closes #3090

to be aligned with the types, as `loading` cannot have an `error` set.
@vercel
Copy link

vercel bot commented Dec 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/FoZ6t7gV4EF1R3bqsD4TwLvE1cYA
✅ Preview: https://react-query-git-fork-tkdodo-feature-3090-set-er-2c8cb8-tanstack.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf826a8:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration
spring-wildflower-v2db8 Issue #3090

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #3106 (bf826a8) into master (2054f5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3106   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          45       45           
  Lines        2270     2270           
  Branches      639      639           
=======================================
  Hits         2190     2190           
  Misses         77       77           
  Partials        3        3           
Impacted Files Coverage Δ
src/core/query.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2054f5b...bf826a8. Read the comment docs.

@TkDodo TkDodo merged commit 3981f52 into TanStack:master Dec 17, 2021
@TkDodo TkDodo deleted the feature/3090-set-error-back-to-null branch December 17, 2021 11:55
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refetching query doesnt set error back to null
2 participants