fix(core): make sure batching finishes if exception is thrown #3216
Conversation
incrementing and decrementing transactions need to happen in an atomic operation, no matter what happens in between; if we increment, but never decrement, we will get to a state where transactions can never become zero - we're basically "leaking" an open transaction. This leads to no observers being informed ever again because we think we still have an open transaction this can be fixed by using try/finally to always decrement the transactions
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/D7v1xqZerUpWfXeSvEcMVHYam8jh |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0ac3b4f:
|
Codecov Report
@@ Coverage Diff @@
## master #3216 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 45 45
Lines 2270 2271 +1
Branches 639 639
=======================================
+ Hits 2190 2191 +1
Misses 77 77
Partials 3 3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.34.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
incrementing and decrementing transactions need to happen in an atomic operation, no matter what happens in between; if we increment, but never decrement, we will get to a state where transactions can never become zero - we're basically "leaking" an open transaction. This leads to no observers being informed ever again because we think we still have an open transaction
this can be fixed by using try/finally to always decrement the transactions
closes #3215