Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): add keys to mapped entries for Explorer #3446

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

Liam-Tait
Copy link
Contributor

@Liam-Tait Liam-Tait commented Mar 27, 2022

Added missing key prop to map fns on Explorer.tsx

Used entry.label as key, which assumes that label is unique

Discovered after converting Explorer component to typescript here

A way to avoid this issue in the future could be to enable eslint-plugin-react's react/jsx-key rule

@vercel
Copy link

vercel bot commented Mar 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/5o3s8G8g2XZntoZHApkwSy6Kb8fr
✅ Preview: https://react-query-git-fork-liam-tait-add-key-to-explo-b7c9f7-tanstack.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 28d0e02:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #3446 (28d0e02) into master (5388160) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #3446   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          45       45           
  Lines        2286     2286           
  Branches      642      642           
=======================================
  Hits         2204     2204           
  Misses         79       79           
  Partials        3        3           
Impacted Files Coverage Δ
src/devtools/Explorer.tsx 76.92% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5388160...28d0e02. Read the comment docs.

@TkDodo TkDodo merged commit 9f23b64 into TanStack:master Mar 27, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants