Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devtools]Missing button styles for buttons under Data Explorer and Query Explorer #3538

Closed
himankpathak opened this issue Apr 20, 2022 · 3 comments · Fixed by #3544
Closed

Comments

@himankpathak
Copy link
Contributor

himankpathak commented Apr 20, 2022

Describe the bug

There are no styles present on buttons inside Data Explorer and Query Explorer.
Therefore text visibility on button fails when global style is applied on button tag.

button {
  color: inherit;
}

Other buttons in devtools are not affected by this which have specific styles present.

Your minimal, reproducible example

https://codesandbox.io/s/inspiring-goldberg-3pecyp

Steps to reproduce

  1. Add the style on button tag
button {
  color: inherit;
}
  1. Open react-query devtools and expand Data Explorer or Query Explorer section.

Expected behavior

Text visibility should not be affected by common generic styles on button tag.
Specific styles can be added on button to prevent this from happening.

How often does this bug happen?

Every time

Screenshots or Videos

image

Platform

  • OS: MacOS
  • Chrome v100.0

react-query version

v3.35.0

TypeScript version

No response

Additional context

No response

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 20, 2022

yeah, the button change was introduced here, and we've already identified the issues:

thanks for creating the ticket to track it. @Liam-Tait wanted to take a look at the two issues, not sure if he already has?

@TkDodo TkDodo added the bug Something isn't working label Apr 20, 2022
Liam-Tait added a commit to Liam-Tait/react-query that referenced this issue Apr 22, 2022
TkDodo pushed a commit that referenced this issue Apr 22, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This issue has been resolved in version 3.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

MMMikeM pushed a commit to MMMikeM/react-query that referenced this issue May 23, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This issue has been resolved in version 4.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants