fix(types): enable more types for first QueryKey #577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables more types beyond just
string
for the first QueryKey but still ensures that it's notnull
/undefined
.queryKeySerializerFn
doesn't play well with TypeScript when removing the first key so TypeScript users will benefit from being able to move their string key to the end of the list instead of having to add an additional argument to their functions.This change will enable the following TypeScript code:
Before this change you'd have to modify your function to accept an additional argument which was unnecessary: