Adding in a function for checking if retries should be performed

[smozely]

Function implemented into the config as per #84

[cherniavskii]

I would love to see function support for "retry" option instead!
That way we'll avoid some edge cases.
What do you think @tannerlinsley @smozely ?
It should not affect compatibility

[smozely]

@cherniavskii so you mean replace the current ‘retry’ being allowed to be true or a number ... and allow it to also be a object that covers all the config for retries?

I’d be happy to do that, but just want to make sure @tannerlinsley is ok with going that direction

[tannerlinsley]

Reverse this order so that the checker isn't even called if it's not true or less than the retry count?

[tannerlinsley]

Yes, I like the idea of just overloading the retry option with the ability to be a function, similar to how retry delays work

[smozely]

Yes, I like the idea of just overloading the retry option with the ability to be a function, similar to how retry delays work

Ah right, so for that your saying, if I provide a function for retry, then that function should handle everything ... so I'd end up with something like ...

config.retry: (failureCount, error) => {
  return failureCount <= 5 && error !== 'NoRetry';
}

So I have to implement both the retry count check in my function, and the extra logic ... I'm all cool with that.

[smozely]

I've updated with the overloading of the retry config item

[cherniavskii]

So I have to implement both the retry count check in my function, and the extra logic

Yeah, I think it's still way better than dealing with edge cases like:

{
  retry: true,
  retryChecker: () => false,
  // what should happen?
}

[cherniavskii]

I don't think we need this check here. If retry is a function, this condition will be falsy

[cherniavskii]

We need to check if retry is a function before calling it

[smozely]

@cherniavskii Thanks for pointing out the mistake with those typeof checks, I also expanded another test which was passing for the wrong reasons with my change

[cherniavskii]

Awesome!

[cherniavskii]

LGTM!

[smozely]

Whoop! thanks folks ... now to replace my home-grown solution with this!