Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add explicit PropsWithChildren to resolve React 18 typedef change #3479

Closed
wants to merge 1 commit into from

Conversation

jafin
Copy link

@jafin jafin commented Apr 8, 2022

Due to changes in the React18 typedefs DefinitelyTyped/DefinitelyTyped#56210
We plan to remove implicit children from @types/react.

Relates to #3476

@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/9qkrMjr3853Cz8b7dYBSRmGRWrHW
✅ Preview: https://react-query-git-fork-jafin-fix-react18-typedef-tanstack.vercel.app

@jafin jafin changed the title fix: Add explicit PropsWithChildren to resolve React 18 typedef chang… fix: Add explicit PropsWithChildren to resolve React 18 typedef change Apr 8, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e16d027:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@nghiepdev
Copy link

Hey, also the Hydrate needs to be updated.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 8, 2022

please see #3476 (comment)

@TkDodo TkDodo closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants