fix: type QueryClientProvider children explicitly #3509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React 18 introduced some breaking type changes. One is that `children` is no longer implicitly typed with `React.FC`. This breaks `QueryClientProvider`, since it relies on implicit children. It can be fixed by typing it explicitly, while it will be no change for users of React 17 or lower.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/CbRetss1nDdHdwRdhChupnfh9dCJ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 633ad2f:
|
|
This is the 3rd time a PR for this was opened. While I appreciate the initiative, please look at the other closed PRs for the reasons why we haven't merged them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React 18 introduced some breaking type changes. One is that
childrenis no longer implicitly typed withReact.FC. This breaksQueryClientProvider, since it relies on implicit children throughReact.FC. It can be fixed by typing it explicitly, while it will be no change for users of React 17 or lower.