fix(persist): introduce in-house synchronous Storage interface #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck#3654) changes context to optional in onSuccess callback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e9d38d6:
|
|
thanks. can you make a PR towards the |
Oops, missed this point, sorry. I mean do You do squash commits 'cause it's a dirty history now |
|
there are conflicts now because we've renamed the directory - in v4, the plugin is no longer experimental |
sorry for a mess, created new "clean" PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently RQ has
createWebStoragePersistorandcreateAsyncStoragePersistorwhich assumes that non-web platforms can have async storages only, which is not true. React Native has performant synchronous MMKV adapters support, which can't be used with RQ 3 right now directly because of interface incompatibility andwindowcheck(already fixed in v4).Related discussion: #3667
Changes
Introduce own
Storageinterface to make possible usingcreateWebStoragePersistorin React Native without TS errors.