fix: range calculated only on scroll #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piecyk
force-pushed
the
fix/range-on-measurements-change-2
branch
from
ab5b417
to
276b86c
Compare
|
@tannerlinsley what do you think about this fix? Will not affect perfomance when scrolling, dynamic size tests have now correct rows rendered. |
|
@tannerlinsley it would be nice to have it in the next release :) |
|
馃帀 This PR is included in version 2.8.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another fix for #112 馃槄 Idea here is very simple, when measurements request for new range, but if scroll is happening in between cancel the request.