Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't do onScroll when there is no element #65

Merged
merged 1 commit into from Sep 14, 2020
Merged

fix: don't do onScroll when there is no element #65

merged 1 commit into from Sep 14, 2020

Conversation

kentcdodds
Copy link
Member

Probably should have tests for this, but I thought I'd throw this together to help push #64 along a bit.

Closes #64

@tannerlinsley tannerlinsley merged commit 5dc6e00 into TanStack:master Sep 14, 2020
@kentcdodds kentcdodds deleted the patch-1 branch September 14, 2020 22:45
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 2.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'scrollTop' of undefined
2 participants
@kentcdodds @tannerlinsley