perf: reuse already measure items, include key into virtualItem #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-virtual/9Mb8qXtFcVR9DxbdDu71A1bdjVQU |
|
@tannerlinsley could you have a look on this when you got a moment? Having a key on item would simplify code in some use-cases 🙏 |
|
ping, would be nice to get this review & released 😉 |
|
👋 Is there any update on when / if this PR will be merged? |
|
Sorry for the delay. This is a good addition! |
|
🎉 This PR is included in version 2.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds small optimisation when creating measurements, as we don't need to rebuild the list from start, only from where item size changed. In addition added
keyvalue on virtualItem.closes #120