Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check signature of webhook #92

Closed
vincvan opened this issue Sep 21, 2017 · 2 comments
Closed

Check signature of webhook #92

vincvan opened this issue Sep 21, 2017 · 2 comments

Comments

@vincvan
Copy link

vincvan commented Sep 21, 2017

It's straightforward, when setting up the controller manually, but I can not find how to check the signature of the webhook, when using the stripe-rails webhook implementation.

@tansengming
Copy link
Owner

so we don't actually check the signature, instead we chose to retrieve the event from Stripe to prove it's validity:

https://github.com/Everapps/stripe-rails/blob/0d78ff5ee41ad09abf38d8917243f69ac1cd24c0/app/models/stripe/event_dispatch.rb#L11-L18

that's why you can't find any signature checking code in the gem.

@tansengming
Copy link
Owner

just a note that we've added signature validation thanks to #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants