Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isLoading and isFetching remain true after an error is returned #22

Closed
ingro opened this issue Nov 8, 2019 · 2 comments
Closed

isLoading and isFetching remain true after an error is returned #22

ingro opened this issue Nov 8, 2019 · 2 comments

Comments

@ingro
Copy link

ingro commented Nov 8, 2019

Hello! I don't know if this is working as intended or not but it sounds a little strange to me.

When a request fails all its given retries, the error property is correctly updated with the Error object returned from the request's Promise, but both isLoading and isFetching properties remain true.

I have created a little codesandbox to show this strange behaviour:

https://codesandbox.io/s/hopeful-mendeleev-3v4xk

@tannerlinsley
Copy link
Collaborator

It was indeed a bug you found with regards to retries and those state flags. I just fixed it in version 0.3.5 which is now available :)

@ingro
Copy link
Author

ingro commented Nov 8, 2019

Thanks for the fast reply and for the fast release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants