result parameter in combine function in useQueries initially empty array
#6612
Labels
Comments
not sure what's up with the sandbox, but it's somehow using an older version of react-query. here is a fork with an update to the latest version that shows the issue: this seems like a regression from: I need to see if I can fix that issue differently. |
TkDodo
added a commit
that referenced
this issue
Dec 29, 2023
The initial fix for #6369 (#6431) introduced a regression where we'd always call combine with an empty array initially. Turns out it was actually on purpose that we didn't call combine in the constructor, but delayed that until the `setQueries` call - because there, we already have complete query result structures available However, there is an optimization that bails out early without calling this.#setResult if "nothing changed"; however, if we call useQueries with an empty array, that means nothing every changes, and the #combinedResult is actually never set, leading to structural sharing never having anything to share with, thus yielding a new reference every time (this is the root issue for #6369). This fix reverts those changes (to avoid calling combine with an empty array every time, thus fixing #6612) and makes sure #setResult is always invoked before bailing out, so that #combinedResult is set correctly even for this case
TkDodo
added a commit
that referenced
this issue
Dec 29, 2023
we only want to stop bailing out if we have no queries; moving the #setResult call unconditionally before the bail-out leads to more re-renders for other useQueries calls now, we only stop the bail-out when the special empty case sets in, which is what fixes #6612
TkDodo
added a commit
that referenced
this issue
Dec 29, 2023
…queries (#6614) * fix(core): make sure to call setResult before the early bail-out The initial fix for #6369 (#6431) introduced a regression where we'd always call combine with an empty array initially. Turns out it was actually on purpose that we didn't call combine in the constructor, but delayed that until the `setQueries` call - because there, we already have complete query result structures available However, there is an optimization that bails out early without calling this.#setResult if "nothing changed"; however, if we call useQueries with an empty array, that means nothing every changes, and the #combinedResult is actually never set, leading to structural sharing never having anything to share with, thus yielding a new reference every time (this is the root issue for #6369). This fix reverts those changes (to avoid calling combine with an empty array every time, thus fixing #6612) and makes sure #setResult is always invoked before bailing out, so that #combinedResult is set correctly even for this case * fix: add a special length check to the bail-out case we only want to stop bailing out if we have no queries; moving the #setResult call unconditionally before the bail-out leads to more re-renders for other useQueries calls now, we only stop the bail-out when the special empty case sets in, which is what fixes #6612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
resultparameter incombinefunction in ReactuseQueriesis initially an empty array. This doesn't match the typing that says each item is a UseQueryResult.Your minimal, reproducible example
https://codesandbox.io/p/devbox/divine-pine-l3nw5l
Steps to reproduce
Run example and look in the console, it shows an error (see screenshot below).
For an unknown reason, the code works in code sandbox, but not when I run the same code example on my machine or my colleague's machine. Please could you try and reproduce locally copying the 3 files in the example?
Expected behavior
I expect queries to be defined on first render, but I receive
undefinedHow often does this bug happen?
Every time
Screenshots or Videos
Error shown on Chrome on my machine:
Platform
Tanstack Query adapter
react-query
TanStack Query version
v5.15.3
TypeScript version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: