Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of previews isn't correct #187

Closed
dreknl opened this issue Sep 8, 2013 · 4 comments
Closed

Alignment of previews isn't correct #187

dreknl opened this issue Sep 8, 2013 · 4 comments

Comments

@dreknl
Copy link
Contributor

dreknl commented Sep 8, 2013

Bug or misunderstanding?

Problem:

  • In 'Slides' mode, the little preview on the left doesn't show a correct preview. The content is shifted.
  • In 'Overview' mode, the previews are also shifted.
  • In 'Present' mode, the alignment of the slides is shifted from the 'Overview' mode.

Tested browsers:

  • Firefox 23.0.1 on openSUSE 12.3 KDE 4.10.5
  • Chromium 30.0.1553.0 (209444) on openSUSE 12.3 KDE 4.10.5
  • Firefox 23.0.1 on Windows XP SP3

Reproduce:

  • make two slides with text -> alignment bug in small previews on the left, see screenshot 1 and 2
  • click on 'Overview' -> misalignment of content of slides, see screenshot 3
  • make first slide larger (e.g. 8 instead of 3), see also screenshot 3
  • align the slides (e.g. top is equal), again see screenshot 3
  • click on 'Present' and the content is correct! But the alignment is not what to expect from the 'Overview', screenshot 4

strut1
strut2
strut3
strut4

@tantaman
Copy link
Owner

Yes, this has been a long standing issue. It should be resolved once I complete the "markdown" integration as that requires a number of updates to the preview windows.

tantaman added a commit that referenced this issue Sep 12, 2013
Need to do some performance testing on very large presentations
to see what the impact of all these changes are.
@tantaman
Copy link
Owner

Preview windows are looking pretty good:
image

Still need to do some testing before it is live.

@dreknl
Copy link
Contributor Author

dreknl commented Sep 12, 2013

Hi,

Appreciate your work! Thanks!
For me, the biggest problem is that the placement of the slides in 'Present' mode is different than the placement of the slides in the 'Overview' mode (see difference in screenshots 3 and 4). The content of the slides in 'Slides' mode is the same as in the 'Present' mode, so I can live with that (but you already fixed it :-) ).

Because the placement of the slides in 'Present' mode is different than the placement of the slides in the 'Overview' mode, it is almost impossible to make the presentation you want. For me, this is basic functionality.

Again, I appreciate your work. So to do something (really small, because I'm no programmer, sorry) in return, I will translate the program in dutch. Despite this is the wrong place to ask, can you tell me how I can change the language now? Or does it take automatically the language of the used browser?

tantaman added a commit that referenced this issue Sep 13, 2013
Updates to slide snapshots to address GH-187
@tantaman
Copy link
Owner

I'd appreciate it. Strut automatically takes the language of the browser. The set of text that needs translation is here: https://github.com/tantaman/Strut/blob/master/app/locales/en.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants