Issue/257 #310
Issue/257 #310
Conversation
| @@ -0,0 +1,19 @@ | |||
| extern crate lz4; | |||
There was a problem hiding this comment.
The goal (of putting the extern crate call here rather than lib.rs) being that we only "include the crate" in the library if that feature was enabled. Correct?
There was a problem hiding this comment.
yes... Alternative I could have added a #[cfg()] thing before hte statement in lib.rs.
src/store/mod.rs
Outdated
| trait Compression { | ||
| fn compress(uncompressed: &[u8], compress: &mut Vec<u8>); | ||
| fn decompress(compressed: &[u8], decompressed: &mut Vec<u8>); | ||
| } |
There was a problem hiding this comment.
Is this to allow an eventual "plug and play"? I didn't see it being used.
| #[cfg(not(feature="lz4"))] | ||
| mod compression_snap; | ||
| #[cfg(not(feature="lz4"))] | ||
| use self::compression_snap::*; |
There was a problem hiding this comment.
Cool, so by default we get snappy, but someone can turn on lz4 with the feature flag. Our snappy lib is a pure rust implementation, but lz4 requires a C library. Sweet.
There was a problem hiding this comment.
yes... LZ4 is probably a nicer compresson/performance trade-off but not by a large margin.
This makes it easier to compile tantivy to web assembly.
* Replaced lz4 by a pure rust implementation of snappy. Closes quickwit-oss#257 * snappy is the default compression. One can use lz4 by enabling the lz4 feature flag. * Removed Compression trait
No description provided.