Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with umlauts in strings (windows) #45

Closed
xkihzew opened this issue Apr 8, 2014 · 5 comments
Closed

Error with umlauts in strings (windows) #45

xkihzew opened this issue Apr 8, 2014 · 5 comments

Comments

@xkihzew
Copy link

xkihzew commented Apr 8, 2014

Hi,

I noticed a bug while freezing/thawing strings with umlauts.
I'm using windows as OS, so this is propably the reason.

Example:

(= "some text with umlauts äöü"
    (nippy/thaw (nippy/freeze "some text with umlauts äöü")))
=> false

This could be fixed in nippy.clj line 189 with (.getBytes x "UTF-8") instead of (.getBytes x)

Thanks.

@ptaoussanis
Copy link
Member

Oh wow, that's a serious bug - I can't believe I missed that. Thank you for the report! I'll push an update in the next few mins...

@ptaoussanis
Copy link
Member

Just pushed v2.6.1 with the fix: https://github.com/ptaoussanis/nippy/releases/tag/v2.6.1

@weavejester
Copy link
Collaborator

I don't see 2.6.1 in Clojars.

@ptaoussanis
Copy link
Member

Hi James, thanks - pushed now! (Thought I had already).

@weavejester
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants