Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dependency tree is much longer that it could be #79

Closed
stathissideris opened this issue Sep 7, 2014 · 4 comments
Closed

The dependency tree is much longer that it could be #79

stathissideris opened this issue Sep 7, 2014 · 4 comments

Comments

@stathissideris
Copy link

If I add timbre to my project, and run lein deps :tree the branch concerning timbre looks like that:

[com.taoensso/timbre "3.3.0"]
  [com.taoensso/encore "1.7.3"]
    [com.keminglabs/cljx "0.4.0"]
      [com.cemerick/piggieback "0.1.3"]
        [org.clojure/clojurescript "0.0-2080"]
          [com.google.javascript/closure-compiler "v20130603"]
            [args4j "2.0.16"]
            [com.google.code.findbugs/jsr305 "1.3.9"]
            [com.google.guava/guava "14.0.1"]
            [com.google.protobuf/protobuf-java "2.4.1"]
            [org.json/json "20090211"]
          [org.clojure/data.json "0.2.3"]
          [org.clojure/google-closure-library "0.0-20130212-95c19e7f0f5f"]
            [org.clojure/google-closure-library-third-party "0.0-20130212-95c19e7f0f5f"]
          [org.mozilla/rhino "1.7R4"]
      [org.clojars.trptcolin/sjacket "0.1.0.6"]
        [net.cgrand/parsley "0.9.1"]
        [net.cgrand/regex "1.1.0"]
      [org.clojure/core.match "0.2.0"]
      [watchtower "0.1.1"]
    [org.clojure/tools.reader "0.8.7"]
  [io.aviso/pretty "0.1.12"]

It seems that excluding cljx does not have an impact (as far as I can tell). Would it be worth excluding this by default so that timbre can truly be an "all-Clojure library" as advertised?

@stathissideris stathissideris changed the title The dependency list is much longer that it could be The dependency tree is much longer that it could be Sep 7, 2014
@hugoduncan
Copy link
Collaborator

This is due to lynaghk/cljx#47. It can be worked around by putting the cljx :plugin entry into the :dev profile.

@ptaoussanis
Copy link
Member

Hi Stathis, this is a regression - thanks for bringing it up. Will cut a new release shortly!

@hugoduncan Yeah, have been bit by this before. Fixed it, then forgot about the problem and reintroduced it :-)

@ptaoussanis
Copy link
Member

Just pushed v3.3.1 which should resolve this. Thanks again for the report!

@stathissideris
Copy link
Author

Great, thanks for the immediate response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants