Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding ClojureScript localization utils #53

Open
ptaoussanis opened this issue Aug 27, 2014 · 4 comments
Open

Consider adding ClojureScript localization utils #53

ptaoussanis opened this issue Aug 27, 2014 · 4 comments

Comments

@ptaoussanis
Copy link
Member

The ClojureScript code currently only provides translation facilities. Input, suggestions, and PRs (especially) welcome on this.

Cheers! :-)

@bensu
Copy link

bensu commented Aug 12, 2015

I'd love to help with the ClojureScript side of things. Is it okay if I start by porting cljx to cljc?

@ptaoussanis
Copy link
Member Author

Hey Sebastian,

Just to clarify: you have in mind some way of adding support for JS-side localization stuff (fmt, parse, etc.)? I'd be very open to that (!), but would suggest we discuss details first (approach, etc.).

In case it's relevant, I should caution that I'll be replacing the entire translations design in a future pending update.

Is it okay if I start by porting cljx to cljc?

cljc requires Clojure 1.7+ which is still pretty new. I've been trying to target Clojure 1.5+ recently (was actually 1.4+ until the release of 1.7). Requiring cljc would potentially break a lot of users, so maybe something best avoided when possible?

@bensu
Copy link

bensu commented Aug 12, 2015

Yes, there are bits of fmt and parse that I'll need to use from ClojureScript, and I'm planning to write wrappers around Google Closure's i18n facilities. To do so, I'll rather work with cljc and the latest ClojureScript. If that is a problem, I'll work on my own following the tower api in a separate project and report back as soon as I have something that can kickstart a discussion.

@ptaoussanis
Copy link
Member Author

I'll work on my own following the tower api in a separate project and report back as soon as I have something that can kickstart a discussion.

Sounds good, feel free to ping if you need anything I can assist with! Cheers :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants