backslash-escaped doublequotes in attributes after removeAttribute #218

milahu · 2022-09-19T14:32:28Z

const { parse } = require('node-html-parser')

var insrc = `\
<html>
  <div id="_" title='"world"' onClick='alert("hello")' color="red">nochange</div>
  <div id="e" title='"world"' color="red">expected</div>
  <div id="a" title='"world"' onClick='alert("hello")' color="red">actual</div>
</html>
`;

var root = parse(insrc);

root.querySelectorAll('#e').forEach(node => {
  node.setAttribute('onClick', "alert('hello')");
})

root.querySelectorAll('#a').forEach(node => {
  //node.setAttribute('title', '"replaced"');
  node.removeAttribute('color'); // FIXME
})

console.log(root.toString());

result

<html>
  <div id="_" title='"world"' onClick='alert("hello")' color="red">nochange</div>
  <div id="e" title="&quot;world&quot;" color="red" onClick="alert('hello')">expected</div>
  <div id="a" title="\"world\"" onClick="alert(\"hello\")">actual</div>
</html>

title="\"world\"" is invalid html

should be either title='"world"' (pretty, minimal diff)
or title=""world"" (ugly, invasive)

The text was updated successfully, but these errors were encountered:

milahu · 2022-09-29T05:49:29Z

similar problem:
newlines in attribute values are escaped as \n but should be 


failing test

diff --git a/test/tests/html.js b/test/tests/html.js
index 3bcf636..8d85725 100644
--- a/test/tests/html.js
+++ b/test/tests/html.js
@@ -391,6 +391,13 @@ describe('HTML Parser', function () {
                                p.getAttribute('c').should.eql('undefined');
                                p.toString().should.eql('<p a="12" b="null" c="undefined"></p>');
                        });
+                       it('should escape newlines to html entities', function () {
+                               const root = parseHTML('<p></p>');
+                               const p = root.firstChild;
+                               p.setAttribute('a', '1\n2');
+                               p.getAttribute('a').should.eql('1\n2');
+                               p.toString().should.eql('<p a="1&#10;2"></p>');
+                       });
                        it('should throw type Error', function () {
                                const root = parseHTML('<p a=12 b=13 c=14></p>');
                                const p = root.firstChild;

kasvith · 2022-10-16T16:36:12Z

this happens when using setAttributes also

taoqf added the bug label Nov 14, 2022

taoqf closed this as completed in 6f6c824 Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

backslash-escaped doublequotes in attributes after removeAttribute #218

backslash-escaped doublequotes in attributes after removeAttribute #218

milahu commented Sep 19, 2022 •

edited

milahu commented Sep 29, 2022

kasvith commented Oct 16, 2022

backslash-escaped doublequotes in attributes after removeAttribute #218

backslash-escaped doublequotes in attributes after removeAttribute #218

Comments

milahu commented Sep 19, 2022 • edited

milahu commented Sep 29, 2022

kasvith commented Oct 16, 2022

milahu commented Sep 19, 2022 •

edited