Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disconnecting from a chromecast #28

Closed
Tapanila opened this issue Jul 29, 2016 · 8 comments
Closed

Support disconnecting from a chromecast #28

Tapanila opened this issue Jul 29, 2016 · 8 comments
Projects

Comments

@Tapanila
Copy link
Owner

No description provided.

@Tapanila
Copy link
Owner Author

Tapanila commented Sep 8, 2016

This is really weird. If anybody has any thoughts how to implement this I would be really interested to talking you about this.

@hansmbakker
Copy link
Collaborator

Maybe not the cleanest way, but what happens if you stop sending ping pong messsages on the heartbeat channel?

Or if you just close the socket connection?

@Tapanila
Copy link
Owner Author

Tapanila commented Sep 8, 2016

I want to make it so after disconnection you can connect to a new chromecast or same one. So basically disposing the underlying socket, stopping the heartbeat and then creating them again or something like that

@hansmbakker
Copy link
Collaborator

hansmbakker commented Sep 8, 2016

Does the new connection need to be done from the same chromecastclient object? I think it is also possible just to create a new instance and optionally to implement idisposable in chromecastclient? (Just looking at the different options)

@Tapanila
Copy link
Owner Author

Tapanila commented Sep 8, 2016

Yep. But then the events are bit tricky. Since the event handlers are hooked into the client and if recreated you loose them.

But I think that might be the best way to go

@ovesennet
Copy link

Any more progress on this? I try to use SharpCaster, but without any way to disconnect and reconnect, it's pretty useless for my scenario.

@Tapanila
Copy link
Owner Author

I got pretty far but started doing other stuff. I will take a look at this on the coming weekend, will post here the status on Sunday.

@Tapanila Tapanila added this to TODO in Plan Feb 13, 2017
@Tapanila
Copy link
Owner Author

Tapanila commented Apr 2, 2017

This is now supported on dev branch.

Might take a while for all of it to be pushed to master and nuget.

@Tapanila Tapanila closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Plan
TODO
Development

No branches or pull requests

3 participants