Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a changelog #517

Closed
aral opened this issue May 20, 2020 · 9 comments
Closed

Keep a changelog #517

aral opened this issue May 20, 2020 · 9 comments

Comments

@aral
Copy link

aral commented May 20, 2020

Use case

Version 5.0.0 is a semver major update with breaking changes but I don’t know where to look for those breaking changes. A changelog would be the first place I’d normally look.

https://keepachangelog.com/en/1.0.0/

Workaround

Do a search in the issues for people reporting breaking changes: https://github.com/substack/tape/issues?q=is%3Aissue+breaking

@aral
Copy link
Author

aral commented May 20, 2020

OK, found them: https://github.com/substack/tape/releases/tag/v5.0.0

Not sure if I looked at a different tag previously. Closing since you already have a comparable system in place.

@aral aral closed this as completed May 20, 2020
@Raynos
Copy link
Collaborator

Raynos commented May 20, 2020

Having breaking changes in a specific markdown file in the repo that we update for every major is beneficial.

The full changelog can stay in git releases.

I like a MIGRATION.md ( https://github.com/optoolco/tonic/blob/master/MIGRATION.md ) where instead of listing breaking changes you document how to migrate and "upgrade/fix" your old code for each breaking change.

@ljharb
Copy link
Collaborator

ljharb commented May 20, 2020

I’m very much in favor of a CHANGELOG.md file; i haven’t yet found a tool that can autogenerate this repo’s precious releases, including backports, properly, and the effort to manually create it is prohibitive. In the meantime, GitHub’s “releases” feature, and specifically, every tag, has release notes for that tag.

For tape, migrating is generally pretty straightforward - that doc would pretty much just contain tips about loose vs strict, and so forth.

@r0mflip
Copy link
Contributor

r0mflip commented May 21, 2020

Is querying GitHub API for all the releases/tags and using the response to build a HISTORY.md style file prohibitive?

@ljharb
Copy link
Collaborator

ljharb commented May 21, 2020

@r0mflip point me to a package that does that, and i'll use it :-)

@r0mflip
Copy link
Contributor

r0mflip commented May 22, 2020

It might exist in an alternate universe but in ours, we probably have yet to create it 😛

@r0mflip
Copy link
Contributor

r0mflip commented May 23, 2020

@ljharb So, I made one https://github.com/r0mflip/logtag

@ljharb

This comment has been minimized.

@ljharb
Copy link
Collaborator

ljharb commented Jan 10, 2024

Done in b467b85.

@ljharb ljharb closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants