Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcbe-rmbackup tries to delete files in wrong directory #41

Closed
jared-hess opened this issue Jun 5, 2021 · 1 comment
Closed

mcbe-rmbackup tries to delete files in wrong directory #41

jared-hess opened this issue Jun 5, 2021 · 1 comment

Comments

@jared-hess
Copy link
Contributor

Looks like mcbe-rmbackup service was never updated when the directory naming convention was switched from CamelCase to snake_case, it still points to "%i_Backups" instead of "%i_backups"

@TapeWerm
Copy link
Owner

TapeWerm commented Jun 5, 2021

Thank you, good catch. I need to remember to git grep for everything that could be affected by a rename, not just vim search in 1 file. When testing, this issue can only happen on case sensitive filesystems like ext4. From October 2017 to May 2021 I ran my Minecraft bedrock server on potato computers, dumping backups to USB drives and SD cards which use case insensitive filesystems like FAT32 or exFAT. When I tried to mv Backups to backups I had to use backups1 as an intermediate filename cause backups resolved to Backups which already existed. Filesystems are a huge footgun, and until I learn automated testing I should grep more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants