Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaN is equal to NaN #84

Closed
wants to merge 1 commit into from
Closed

Conversation

AndreasMadsen
Copy link

Fixes #83

This changes:

  • t.deepEqual
  • t.equal
  • t.like

and there opposites

@othiym23
Copy link
Contributor

This is an oddity of IEEE754, but that doesn't mean that tap should paper over it unless a developer specifically wants that behavior. IMHO this shouldn't be the default.

@isaacs
Copy link
Member

isaacs commented Jul 23, 2013

I'd be ok with adding t.is() and t.deepIs() methods, but changing equal is not a good idea.

@isaacs isaacs closed this Jul 23, 2013
@isaacs
Copy link
Member

isaacs commented Jul 23, 2013

Actually, like() is probably fine to change in this way.

@pc-dedelhart
Copy link

Can't you do an isNaN() around the result and compare the two?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN as a special case
4 participants