Move slash replacement to the end #483
Conversation
Make sure the slash replacement is done
|
Just tested this manually from my I would buy you guys a coffee if you can patch this soon :) |
lib/test.js
Outdated
| ' ' + (this.name || '').trim() | ||
| : path.basename(main)) + ' ' + (this.name || '').trim() | ||
|
|
||
| return name.replace(/\\/g, '/') |
There was a problem hiding this comment.
Won't this be an issue if you want to have a slash in the name?
For example: t.test('make sure \\ is replaced with /', t => { ... }) would result in some confusing output.
There was a problem hiding this comment.
Oh, yes you are right. Not sure why the current one doesnt work even though the replacement. Whats a more suitable place to handle this? Any hints are appreciated.
There was a problem hiding this comment.
Yeah, I'm guessing that maybe the name is getting set somewhere in the Spawn subclass perhaps? I'd been using the Windows support on Travis briefly, but ran into too many issues around signal and subprocess differences, so I think the only way forward is for me (or someone) to spin up a Windows VM and get all the tests passing locally first. The turnaround is just too slow to do with a remote CI system otherwise, and a known-failing test is worse than no test at all.
|
I am confused actually. The version I have (^12.0.0) has a different Not sure why semver is not bumping to next minor version which this was fixed |
|
Oh! Looks like I never published the code on master branch, because I was still fantasizing that I'd get everything passing on Windows first. Maybe I should just bite the bullet and accept it as-is :) |
|
Since I use windows, I can try getting tests to run locally first. Not sure how tough it will be for me though, this project looks beyond my skills but I am up for the challange :) |
Make sure the slash replacement is done