Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get our test suite running on Windows #23

Merged
merged 5 commits into from
May 16, 2016
Merged

fix: get our test suite running on Windows #23

merged 5 commits into from
May 16, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented May 16, 2016

gets the tests running on Windows, so that we can have more confidence that we're not breaking upstream dependencies like nyc and loud-rejection.

reviewers: @isaacs, @parshap

@coveralls
Copy link

coveralls commented May 16, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-1.08%) to 95.349% when pulling 7057357 on windows-fixes into 100163a on master.

@coveralls
Copy link

coveralls commented May 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 96.512% when pulling 213b7d8 on windows-fixes into 100163a on master.

@coveralls
Copy link

coveralls commented May 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.08%) to 96.512% when pulling 7c3771a on windows-fixes into 100163a on master.

@isaacs
Copy link
Member

isaacs commented May 16, 2016

Lgtm :)

@bcoe bcoe merged commit 6f3eda8 into master May 16, 2016
@bcoe bcoe deleted the windows-fixes branch May 16, 2016 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoe @coveralls @isaacs