exitCode type does not match the one of nodejs 20 ?

[kapouer]

(ask the cat why there is an initial empty issue - sorry for this)

It looks like there is a problem when building signal-exit on node 20 (on my debian env, with non-pristine nodejs stuff).

src/index.ts(304,34): error TS2345: Argument of type 'string | number | undefined' is not assignable to parameter of type 'number | null | undefined'.

@types/node 20.12.12 indeed has a different definition for process.exitCode.
It might very well be a problem only me is seeing, but it might not !

Miaw

[kapouer]

This inelegantly fixes the issue:

--- a/src/index.ts
+++ b/src/index.ts
@@ -301,7 +301,8 @@
       /* c8 ignore start */
       const ret = og.call(this.#process, ev, ...args)
       /* c8 ignore start */
-      this.#emitter.emit('exit', this.#process.exitCode, null)
+      const code = this.#process.exitCode
+      this.#emitter.emit('exit', typeof code == "string" ? parseInt(code) : code, null)
       /* c8 ignore stop */
       return ret
     } else {