-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in v1.0.3 #56
Comments
Oh looking at https://github.com/tapjs/stack-utils/commits/v1-legacy it seems that v1.0.3 is based on v2.0.3 and not v1.0.2? |
Yeah, there were a bunch of fixes to make it behave properly on node 14 and 15. Re-implementing all of those in v1 piecemeal was not realistic. I've updated it to work on node 4 and 6. If you are using versions of node that haven't gotten critical security updates in 4 years (to say nothing of normal improvements and bugfixes), you should really be locking down all your deps, even to the point of checking them all into source control, and never updating anything without thoroughly vetting it. The cost of keeping modules like this working on those ancient platforms is not worth the significant effort. At the very least, pin all your versions. It is cheaper and wiser for you to update your node version than it is for me to continue supporting it. I wouldn't update anything until you update your node version. Failing CI should really be the least of your worries. If you are willing to invest the effort to make it work, I would accept a pull request to restore 0.10 and 0.12 support, provided it didn't change any behavior otherwise. But you'll have to also update |
Thanks for the release. We will remove support for Node.js 6 and 8 in the next major release (in a few months), because you are right and it's painful to keep supporting them. I personally don't care about 0.10 and 0.12, so unless someone else complains about them it's ok to leave them unsupported I guess. |
v1.0.2 supports Node.js 0.10.0:
stack-utils/package.json
Line 13 in 2d238df
However, in v1.0.3 it was bumped to Node.js 8:
stack-utils/package.json
Line 16 in 85ad2ca
We still test Babel on Node.js 6, somewhere in our dependencies tree there is
stack-utils@^1.0.1
. However, it doesn't work anymore becausestack-utils@1.0.3
uses a trailing comma in function arguments, which doesn't work on Node.js 6.The text was updated successfully, but these errors were encountered: