Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files not loaded from .taprc #438

Closed
jhessin opened this issue Apr 13, 2018 · 1 comment
Closed

files not loaded from .taprc #438

jhessin opened this issue Apr 13, 2018 · 1 comment

Comments

@jhessin
Copy link

jhessin commented Apr 13, 2018

My package.json test script runs TAP_RCFILE=./.taprc tap and my .taprc file looks like this:

color: true
reporter: tap
files: [ ./test.js ]

Expected result: running yarn test will run the tests in test.js.

Actual result: I get a usage blob from running yarn test

Workaround: I can get the expected result if I append a -- to the end of the script. Why is this?

@isaacs isaacs closed this as completed in 3346fc1 Apr 13, 2018
@isaacs
Copy link
Member

isaacs commented Apr 13, 2018

Thanks for the report! Fixed on the latest publish. From the commit message:

Don't require argv file list if specified in taprc

Previously, checking for specified test files was done by looking at
argv.length.  So, if a `files` config was specified in taprc, it would
work if a `--` was passed in on the command line, but otherwise would
dump the usage message one sees when running `tap` with no arguments (or
would wait for stdin if not run on a TTY).

Fix #438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants