Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed output should include child test descriptions #55

Closed
thlorenz opened this issue Sep 8, 2012 · 2 comments
Closed

Detailed output should include child test descriptions #55

thlorenz opened this issue Sep 8, 2012 · 2 comments

Comments

@thlorenz
Copy link
Contributor

thlorenz commented Sep 8, 2012

When running the below with node tapme.js

// tapme.js
var test = require('tap').test;

test('parent test description', function (t) {
  t.plan(2)
  t.ok(true, 'test in parent')
  t.test('child test description', function (t) {
    t.plan(1)
    t.ok(true, 'test in child')  
  })
})

it outputs:

TAP version 13
# parent test description
ok 1 test in parent
ok 2 test in child

1..2
# tests 2
# pass  2

# ok

It would be nice if it could include the child test description before test 2, e.g., :

TAP version 13
# parent test description
ok 1 test in parent
# child test description  
ok 2 test in child

[...]

If you agree that this is a valid request I'd be willing to fix it myself and submit a PR, just wanted to get your opinion on this first.

@isaacs
Copy link
Member

isaacs commented Sep 8, 2012

Yes. Child test names should be emitted as comments.

@thlorenz
Copy link
Contributor Author

Any plans on pulling this in or suggestions in case improvements are needed?

@isaacs isaacs closed this as completed in 247fec9 Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants