Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced language setting via variable #91

Closed
1 task done
SAOPP opened this issue Apr 4, 2022 · 11 comments · Fixed by #94
Closed
1 task done

Forced language setting via variable #91

SAOPP opened this issue Apr 4, 2022 · 11 comments · Fixed by #94
Assignees
Labels
type:feature_request Feature request

Comments

@SAOPP
Copy link

SAOPP commented Apr 4, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem to be solved

Hi!

Now the service can automatically determine the locale settings and install the language, I have a question, is it possible to set the desired language through a variable to turn off this check?

For example, I need only English, how can I do it now? Thank u in advance!

Suggest a solution

Add environment variable for set up language of pages.

Additional context

No response

@SAOPP SAOPP added the type:feature_request Feature request label Apr 4, 2022
@tarampampam
Copy link
Owner

Hi @SAOPP!

Could you please explain what's the reason for your request? Automatic localization based on the browser locale (and nothing more), it's like a small piece of sugar for the end-users :) Maybe you have some problems with it?

@SAOPP
Copy link
Author

SAOPP commented Apr 4, 2022

Okay, why I have an english locale but I got russian pages? I think automatically detect it's not really cool, and I talked about variable for native setting this up.

@tarampampam
Copy link
Owner

Ok 👌, I will implement a flag for this a little bit later, ok?

@SAOPP
Copy link
Author

SAOPP commented Apr 4, 2022

Np homie 😃 I still initially tried to understand whether it would be difficult to implement, thank u very much. 👍

@tarampampam
Copy link
Owner

tarampampam commented Apr 5, 2022

Could you please test changes in #94? Docker image (just for a test) tarampampam/error-pages:toogle-l10n

But, implemented flag allows only disabling auto-localization (all pages will be in en locale by default) and forcing any other locale looks useless to me (not sure).

@tarampampam
Copy link
Owner

Ping @SAOPP

@tarampampam
Copy link
Owner

@SAOPP are you ok?

@SAOPP
Copy link
Author

SAOPP commented Apr 12, 2022

Hey, sorry, missed up. I will test it. 👍

@tarampampam
Copy link
Owner

Not a problem dude, I understand

@SAOPP
Copy link
Author

SAOPP commented Apr 12, 2022

Yes, everything works, the language is ignored if you put non-English higher in the list in browser. 👍

Btw, I would like to apologize for the fact that when I wrote this issue, I didn't keep track of the fact that for some reason my 'non-English' language was higher than English language is Chrome, which is why I actually wrote this issue - because in the list of languages in It's not obvious to Chrome that it's from this list that the language is defined as the main language. I'm not sure if I explained it clearly enough, let me know.

@tarampampam
Copy link
Owner

🔥 v2.13.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature_request Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants